Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRS-125 Add integration with prison-api and rudimentary prisoner details page. Also add open-api scripts to auto generate API types via the swagger URL #9

Merged
merged 1 commit into from
Jul 30, 2021
Merged

CRS-125 Add integration with prison-api and rudimentary prisoner details page. Also add open-api scripts to auto generate API types via the swagger URL #9

merged 1 commit into from
Jul 30, 2021

Conversation

yasinmustafa
Copy link
Contributor

@yasinmustafa yasinmustafa commented Jul 30, 2021 •
edited
Loading

  • Scripts to pull the API types from their swagger definitions in DEV x 2 (prisonApi, prisonerOffenderSearchApi)
  • Imported generated API types as Typescript interfaces.
  • Wired these generated types into the API clients, services, routes and tests.
  • Added a prisoner profile page for testing in DEV.
  • Added the prisoner image route, service and client functions.
prisoner-details.mp4

@yasinmustafa
CRS-125 Add integration with prison-api and rudimentary prisoner deta…
f16c132 
…ils page. Also add open-api scripts to auto generate API types via the swagger URL
timharrison-moj
timharrison-moj approved these changes Jul 30, 2021
View reviewed changes
Copy link

@timharrison-moj timharrison-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks familiar ;-) and LGTM.

@timharrison-moj timharrison-moj merged commit 8956346 into main Jul 30, 2021
@timharrison-moj timharrison-moj deleted the CRS-125-add-prisoner-apis branch July 30, 2021 09:48
carloveo-moj pushed a commit that referenced this pull request Jan 31, 2024
@andrewrlee
Reducing docker image size (#9)
ac0dfa6 
Also
* Update dependencies
* Adopt standard github gitignore for node projects
* Using body typography
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timharrison-moj timharrison-moj timharrison-moj approved these changes

@joelstobart-moj joelstobart-moj Awaiting requested review from joelstobart-moj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yasinmustafa @timharrison-moj