Migrating project to use groups in allowlist #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By referring to groups to IP addresses, we can centralize the definition of groups of ip addresses. If these lists require changing in the future, we can change the definition once and future deploys across all services will automatically include these new IPs. 2 allowlist(s) have been detected that can be migrated. ## Allowlist: helm_deploy/values-dev.yaml ### New Groups The effect of applying this PR is as follows: - The following groups will be applied: `internal,prisons` - The size of the allowlist defined in this file will change: `29 => 1 (28 removed)` ### Added IPs The new Group membership will result in the following IPs being added to your allowlist by applying this PR: - mojo-azure-landing-zone-public-egress-1 - mojo-azure-landing-zone-public-egress-2 - mojo-azure-landing-zone-public-egress-3 - mojo-azure-landing-zone-public-egress-4 ### Removed IPs The following IPs have been identified as unnecessary and will be removed by applying this PR: - health-kick - ark-dom1-psn1 - ark-dom1-psn2 - dxc_webproxy1 - dxc_webproxy2 - dxc_webproxy3 - dxc_webprox23 - quantum - quantum_alt - quantum3 ## Allowlist: helm_deploy/values-preprod.yaml ### New Groups The effect of applying this PR is as follows: - The following groups will be applied: `internal,prisons` - The size of the allowlist defined in this file will change: `28 => 0 (28 removed)` ### Added IPs The new Group membership will result in the following IPs being added to your allowlist by applying this PR: - mojo-azure-landing-zone-public-egress-1 - mojo-azure-landing-zone-public-egress-2 - mojo-azure-landing-zone-public-egress-3 - mojo-azure-landing-zone-public-egress-4 ### Removed IPs The following IPs have been identified as unnecessary and will be removed by applying this PR: - health-kick - ark-dom1-psn1 - ark-dom1-psn2 - dxc_webproxy1 - dxc_webproxy2 - dxc_webproxy3 - dxc_webprox23 - quantum - quantum_alt - quantum3
By referring to groups to IP addresses, we can centralize the definition of groups of ip addresses. If these lists require changing in the future, we can change the definition once and future deploys across all services will automatically include these new IPs. 2 allowlist(s) have been detected that can be migrated. ## Allowlist: helm_deploy/values-dev.yaml ### New Groups The effect of applying this PR is as follows: - The following groups will be applied: `internal,prisons` - The size of the allowlist defined in this file will change: `29 => 1 (28 removed)` ### Added IPs The new Group membership will result in the following IPs being added to your allowlist by applying this PR: - mojo-azure-landing-zone-public-egress-1 - mojo-azure-landing-zone-public-egress-2 - mojo-azure-landing-zone-public-egress-3 - mojo-azure-landing-zone-public-egress-4 ### Removed IPs The following IPs have been identified as unnecessary and will be removed by applying this PR: - health-kick - ark-dom1-psn1 - ark-dom1-psn2 - dxc_webproxy1 - dxc_webproxy2 - dxc_webproxy3 - dxc_webprox23 - quantum - quantum_alt - quantum3 ## Allowlist: helm_deploy/values-preprod.yaml ### New Groups The effect of applying this PR is as follows: - The following groups will be applied: `internal,prisons` - The size of the allowlist defined in this file will change: `28 => 0 (28 removed)` ### Added IPs The new Group membership will result in the following IPs being added to your allowlist by applying this PR: - mojo-azure-landing-zone-public-egress-1 - mojo-azure-landing-zone-public-egress-2 - mojo-azure-landing-zone-public-egress-3 - mojo-azure-landing-zone-public-egress-4 ### Removed IPs The following IPs have been identified as unnecessary and will be removed by applying this PR: - health-kick - ark-dom1-psn1 - ark-dom1-psn2 - dxc_webproxy1 - dxc_webproxy2 - dxc_webproxy3 - dxc_webprox23 - quantum - quantum_alt - quantum3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the project to use groups of IPs in their allowlist.
By referring to groups to IP addresses, we can centralize the definition of groups of ip addresses.
If these lists require changing in the future, we can change the definition once and future deploys across all services will automatically include these new IPs.
2 allowlist(s) have been detected that can be migrated.
Allowlist: helm_deploy/values-dev.yaml
New Groups
The effect of applying this PR is as follows:
internal,prisons29 => 1 (28 removed)Added IPs
The new Group membership will result in the following IPs being added to your allowlist by applying this PR:
mojo-azure-landing-zone-public-egress-1
mojo-azure-landing-zone-public-egress-2
mojo-azure-landing-zone-public-egress-3
mojo-azure-landing-zone-public-egress-4
Removed IPs
The following IPs have been identified as unnecessary and will be removed by applying this PR:
health-kick
ark-dom1-psn1
ark-dom1-psn2
dxc_webproxy1
dxc_webproxy2
dxc_webproxy3
dxc_webprox23
quantum
quantum_alt
quantum3
Allowlist: helm_deploy/values-preprod.yaml
New Groups
The effect of applying this PR is as follows:
internal,prisons28 => 0 (28 removed)Added IPs
The new Group membership will result in the following IPs being added to your allowlist by applying this PR:
mojo-azure-landing-zone-public-egress-1
mojo-azure-landing-zone-public-egress-2
mojo-azure-landing-zone-public-egress-3
mojo-azure-landing-zone-public-egress-4
Removed IPs
The following IPs have been identified as unnecessary and will be removed by applying this PR:
health-kick
ark-dom1-psn1
ark-dom1-psn2
dxc_webproxy1
dxc_webproxy2
dxc_webproxy3
dxc_webprox23
quantum
quantum_alt
quantum3