Implement physical attributes NOMIS to DPS synchronisation #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehalmamoj
force-pushed
the
mh-SDI-1816-synchronise-physical-attributes
branch
from
ea2de39
to
4787f7d
Compare
mikehalmamoj
force-pushed
the
mh-SDI-1816-synchronise-physical-attributes
branch
from
77afd31
to
424107c
Compare
andymarke
reviewed
Jun 21, 2024
|
|
||
| sendPhysicalAttributesChangedEvent() | ||
|
|
||
| verifyResults(type = "ignored", reason = "New physical attributes are empty") |
There was a problem hiding this comment.
Question; are physical attributes not copied by NOMIS for new bookings (like it does for Alerts)?
There was a problem hiding this comment.
They are yes. This test is for a brand new booking - if you go into the physical info NOMIS screen it creates this "empty" record which makes no sense to synchronise.
andymarke
reviewed
Jun 21, 2024
| } | ||
|
|
||
| @Test | ||
| fun `should put message on DLQ if booking has no physical attributes`() = runTest { |
There was a problem hiding this comment.
We shouldn't be receiving events for bookings without any physical attributes - but I chose not to assume that in the code, so had to handle the error scenario. Should never happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.