Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTP-1980: Upgrade to govuk-frontend 5.3 #608

Merged
merged 1 commit into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Upgrade to govuk-frontend 5.3 and use new password input component on…
… login page
  • Loading branch information
ushkarev committed Mar 27, 2024
commit fa5274e6eb8b8041634052ab5cf70ff10b1e9895
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export var SelectAll = {

onCheckKeypress: function (e) {
// disallow submitting form with enter key
if (e.keyCode === 13) {
if (e.key === 'Enter') {
e.preventDefault();
return false;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export var Disbursements = {
initRemittanceDescription: function () {
// prevent new lines in wrapped textareas
$('#id_remittance_description').keydown(function (e) {
return e.keyCode !== 13;
return e.key !== 'Enter';
});
},

Expand Down
2 changes: 1 addition & 1 deletion mtp_cashbook/templates/mtp_auth/login.html
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ <h2 class="govuk-heading-m">{% trans 'Sign in' %}</h2>
<input type="hidden" name="next" value="{{ next }}">

{% include 'mtp_common/forms/field.html' with field=form.username input_classes='govuk-input--width-10' only %}
{% include 'mtp_common/forms/field.html' with field=form.password input_classes='govuk-input--width-10' only %}
{% include 'mtp_common/forms/password-field.html' with field=form.password only %}

<button type="submit" class="govuk-button" data-module="govuk-button" name="signin">{% trans 'Sign in' %}</button>
</form>
Expand Down
2 changes: 1 addition & 1 deletion requirements/base.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Dependencies needed for all environments

money-to-prisoners-common~=16.9.0
money-to-prisoners-common~=16.10.0
2 changes: 1 addition & 1 deletion requirements/dev.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Place development and testing dependencies here

money-to-prisoners-common[testing]~=16.9.0
money-to-prisoners-common[testing]~=16.10.0

-r base.txt