🔀 🐛 Correct issue causing crash if offenderDetail request fails (#572)

* 🐛 Correct issue causing crash if offenderDetail request fails Signed-off-by: theDustRoom <paul.massey@digital.justice.gov.uk> * ♻️ Refactor Signed-off-by: theDustRoom <paul.massey@digital.justice.gov.uk>
ministryofjustice · May 18, 2022 · 394ff58 · 394ff58
1 parent 243bf85
commit 394ff58
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/server/routes/index.js b/server/routes/index.js
@@ -538,13 +538,13 @@ module.exports = function Index ({ authenticationMiddleware }) {
     const probationStatusDetails = await getProbationStatusDetails(crn)
     return await updateOffender(defendantId, {
       probationStatus: probationStatusDetails.status,
-      crn: offenderDetail.otherIds && offenderDetail.otherIds.crn,
+      crn: offenderDetail && offenderDetail.otherIds ? offenderDetail.otherIds.crn : undefined,
       previouslyKnownTerminationDate: probationStatusDetails.previouslyKnownTerminationDate,
       breach: probationStatusDetails.inBreach,
       preSentenceActivity: probationStatusDetails.preSentenceActivity,
       awaitingPsr: probationStatusDetails.awaitingPsr,
-      pnc: sendPncAndCroWithOffenderUpdates && offenderDetail.otherIds ? offenderDetail.otherIds.pncNumber : undefined,
-      cro: sendPncAndCroWithOffenderUpdates && offenderDetail.otherIds ? offenderDetail.otherIds.croNumber : undefined
+      pnc: sendPncAndCroWithOffenderUpdates && offenderDetail && offenderDetail.otherIds ? offenderDetail.otherIds.pncNumber : undefined,
+      cro: sendPncAndCroWithOffenderUpdates && offenderDetail && offenderDetail.otherIds ? offenderDetail.otherIds.croNumber : undefined
     })
   }