Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIC-4093: Code change to display matching defendant records in descen… #990

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

PIC-4093: Code change to display matching defendant records in descen… #990

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d6476c0
PIC-4093: Code change to display matching defendant records in descen…
sameermoj Sep 18, 2024
bdd3d40
PIC-4093: Changes based on review
sameermoj Sep 25, 2024
13ac54f
build(deps-dev): bump webpack from 5.89.0 to 5.94.0 (#980)
dependabot[bot] Sep 27, 2024
3a55106
PIC-4093: Changes based on review
sameermoj Sep 28, 2024
920a24f
PIC-4093: Changes based on review
sameermoj Sep 28, 2024
9282a18
PIC-4093: Changes based on review
sameermoj Sep 28, 2024
204b778
PIC-4093: Changes based on review
sameermoj Sep 28, 2024
b62d16c
PIC-4093: Code changes based on reviews
sameermoj Sep 28, 2024
e7ad811
PIC-4093: Code changes based on reviews
sameermoj Sep 28, 2024
98f5ca9
PIC-4093: Code changes based on reviews
sameermoj Sep 28, 2024
f0926d4
PIC-4093: Changes based on review
sameermoj Sep 18, 2024
8601495
Merge remote-tracking branch 'origin/PIC-4093' into PIC-4093
sameermoj Sep 28, 2024
1541ad6
PIC-4093: Code changes based on reviews
sameermoj Sep 28, 2024
9c77641
PIC-4093: Code changes based on reviews
sameermoj Sep 28, 2024
a2e63e4
PIC-4093: Code changes based on reviews
sameermoj Sep 29, 2024
914e25a
PIC-4093: Code changes based on reviews
sameermoj Sep 29, 2024
f8afbc7
PIC-4093: Code changes based on reviews
sameermoj Sep 29, 2024
135302a
PIC-4093: Code changes based on reviews
sameermoj Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PIC-4093: Changes based on review
  • Loading branch information
@sameermoj
sameermoj committed Sep 28, 2024
commit 204b7789e109ed2f5b5209b1df23eb782011b58b
4 changes: 4 additions & 0 deletions public/src/stylesheets/app/_overrides.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@

.pac-\!-grid-column-45 {
width: 45%;
}

.pac-\!-grid-column-sticky-45 {
width: 45%;
padding: 10px 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried that putting this here with mean if someone uses this in the future we have these overrides.... Could we add it as an additional class ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we have the handler in a new routing file - we need to make sure we have unit tests for it too. I can help you with these. We either follow a given, when, then style or I use arrange, act, assert which is much the same.

position: sticky;
top: 20px;
Expand Down
2 changes: 1 addition & 1 deletion server/views/match-defendant.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@

<form name="matchDefendant" id="matchDefendant" method="post">
<div class="govuk-grid-row">
<div class="govuk-grid-column-one-half pac-!-grid-column-45 govuk-!-padding-right-9">
<div class="govuk-grid-column-one-half pac-!-grid-column-sticky-45 govuk-!-padding-right-9">

<h3 class="govuk-heading-m">Defendant details</h3>

Expand Down