Update aws.js #94
Open
Update aws.js #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amazon keeps many products country separated. And each different country has own end point address. For ex: for France, while end point address is "webservices.amazon.fr/onca/xml", for USA this adrress is "webservices.amazon.com/onca/xml". it can be checked at http://docs.aws.amazon.com/AWSECommerceService/latest/DG/AnatomyOfaRESTRequest.html. So if this call method has selective host address option as a parameter, it will give us to flexibility when call product api, and no need to create new instance for requesting other amazon end points. By this way, we need to just single instance for all amazons' end points. this change on aws.js requires some changes in prodAdv.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazon keeps many products country separated. And each different country has own end point address. For ex: for France, while end point address is "webservices.amazon.fr/onca/xml", for USA this adrress is "webservices.amazon.com/onca/xml". it can be checked at http://docs.aws.amazon.com/AWSECommerceService/latest/DG/AnatomyOfaRESTRequest.html.
So if this call method has selective host address option as a parameter, it will give us to flexibility when call product api, and no need to create new instance for requesting other amazon end points.
By this way, we need to just single instance for all amazons' end points.
this change on aws.js requires some changes in prodAdv.js.