fix corner case in if_return (#5755)

fixes #5754
mishoo · Dec 2, 2022 · 404794f · 404794f
1 parent 650e63c
commit 404794f
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 1 deletion.
diff --git a/lib/compress.js b/lib/compress.js
@@ -3759,7 +3759,10 @@ Compressor.prototype.compress = function(node) {
                     if (!in_lambda) return false;
                     if (!(ab instanceof AST_Return)) return false;
                     var value = ab.value;
-                    if (value && !is_undefined(value.tail_node())) return false;
+                    if (value) {
+                        if (!drop_return_void) return false;
+                        if (!is_undefined(value.tail_node())) return false;
+                    }
                     if (!(self instanceof AST_SwitchBranch)) return true;
                     if (!jump) return false;
                     if (jump instanceof AST_Exit && jump.value) return false;

diff --git a/test/compress/yields.js b/test/compress/yields.js
@@ -2169,3 +2169,41 @@ issue_5749_2: {
     expect_stdout: "PASS"
     node_version: ">=4"
 }
+
+issue_5754: {
+    options = {
+        if_return: true,
+    }
+    input: {
+        async function* f(a, b) {
+            try {
+                if (a)
+                    return void 0;
+            } finally {
+                console.log(b);
+            }
+        }
+        f(42, "foo").next();
+        f(null, "bar").next();
+        console.log("baz");
+    }
+    expect: {
+        async function* f(a, b) {
+            try {
+                if (a)
+                    return void 0;
+            } finally {
+                console.log(b);
+            }
+        }
+        f(42, "foo").next();
+        f(null, "bar").next();
+        console.log("baz");
+    }
+    expect_stdout: [
+        "bar",
+        "baz",
+        "foo",
+    ]
+    node_version: ">=10"
+}