fix corner case in unused (#5906)

fixes #5905
mishoo · Aug 4, 2024 · 8bbbc51 · 8bbbc51
1 parent 76803d6
commit 8bbbc51
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 8 deletions.
diff --git a/lib/compress.js b/lib/compress.js
@@ -9349,17 +9349,18 @@ Compressor.prototype.compress = function(node) {
             var expr = self.expression;
             if (expr.may_throw_on_access(compressor)) return self;
             var prop = self.property;
-            var optional = self.optional;
-            if (!optional) {
-                expr = expr.drop_side_effect_free(compressor, first_in_statement);
-                if (!expr) return prop.drop_side_effect_free(compressor, first_in_statement);
+            if (self.optional) {
+                prop = prop.drop_side_effect_free(compressor);
+                if (!prop) return expr.drop_side_effect_free(compressor, first_in_statement);
+                self = self.clone();
+                self.property = prop;
+                return self;
             }
+            expr = expr.drop_side_effect_free(compressor, first_in_statement);
+            if (!expr) return prop.drop_side_effect_free(compressor, first_in_statement);
             prop = prop.drop_side_effect_free(compressor);
             if (!prop) return expr;
-            if (!optional) return make_sequence(self, [ expr, prop ]);
-            self = self.clone();
-            self.property = prop;
-            return self;
+            return make_sequence(self, [ expr, prop ]);
         });
         def(AST_SymbolRef, function(compressor) {
             return this.is_declared(compressor) && can_drop_symbol(this, compressor) ? null : this;

diff --git a/test/compress/optional-chains.js b/test/compress/optional-chains.js
@@ -669,3 +669,27 @@ issue_5900: {
     expect_stdout: "PASS"
     node_version: ">=14"
 }
+
+issue_5905: {
+    options = {
+        pure_getters: "strict",
+        reduce_vars: true,
+        toplevel: true,
+        unused: true,
+    }
+    input: {
+        var a;
+        do {
+            var b = a++;
+            var c = c ?? b?.[42];
+        } while (console.log("PASS"));
+    }
+    expect: {
+        var a;
+        do {
+            a++;
+        } while (console.log("PASS"));
+    }
+    expect_stdout: "PASS"
+    node_version: ">=14"
+}