Skip to content

Commit

Permalink
fix corner case in collapse_vars (#5780)
Browse files Browse the repository at this point in the history
fixes #5779
  • Loading branch information
alexlamsl authored Jan 16, 2023
1 parent a437a61 commit f0ca9cf
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 1 deletion.
5 changes: 5 additions & 0 deletions lib/compress.js
Original file line number Diff line number Diff line change
Expand Up @@ -1761,6 +1761,11 @@ Compressor.prototype.compress = function(node) {

var identifier_atom = makePredicate("Infinity NaN undefined");
function is_lhs_read_only(lhs, compressor) {
if (lhs instanceof AST_Assign) {
if (lhs.operator != "=") return true;
if (lhs.right.tail_node().is_constant()) return true;
return is_lhs_read_only(lhs.left, compressor);
}
if (lhs instanceof AST_Atom) return true;
if (lhs instanceof AST_ObjectIdentity) return true;
if (lhs instanceof AST_PropAccess) {
Expand Down
26 changes: 25 additions & 1 deletion test/compress/collapse_vars.js
Original file line number Diff line number Diff line change
Expand Up @@ -9864,7 +9864,8 @@ issue_5276: {
}
expect: {
var a = A = "PASS";
a.p = a.p + null - 42;
a.p += null;
a.p -= 42;
console.log(a);
}
expect_stdout: "PASS"
Expand Down Expand Up @@ -10148,3 +10149,26 @@ issue_5719: {
}
expect_stdout: "PASS"
}

issue_5779: {
options = {
collapse_vars: true,
evaluate: true,
pure_getters: "strict",
reduce_vars: true,
toplevel: true,
}
input: {
var a = A = "foo";
a.p = 42;
if (a && !a.p)
console.log("PASS");
}
expect: {
var a = A = "foo";
a.p = 42;
if (a, !a.p)
console.log("PASS");
}
expect_stdout: "PASS"
}

0 comments on commit f0ca9cf

Please sign in to comment.