ci: Get api.json from Misskeyでupload-artifact@v4で同名artifactでエラーになるのを修正 #12770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: おさむのひと <46447427+samunohito@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12770 +/- ##
===========================================
+ Coverage 79.79% 79.89% +0.10%
===========================================
Files 956 956
Lines 108800 108800
Branches 8373 8403 +30
===========================================
+ Hits 86814 86927 +113
+ Misses 21986 21873 -113 ☔ View full report in Codecov by Sentry. |
|
backwords compatibiltyは持たせたので古いget-api-diffの結果を新しいreport-api-diffでレポートすることはできますが、forword compatibilityはもたせてないので新しいget-api-diffの結果を古いreport-api-diffでレポートしようとしているこのブランチのreport-api-diffが落ちてるのはexpectedです |
|
🙏🙏 |
|
🙏 |
5 tasks
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
misskey-dev#12770) * ci: upload-artifact@v4で同名artifactでエラーになるのを修正 Co-authored-by: おさむのひと <46447427+samunohito@users.noreply.github.com> * report-api-diff.ymlの最中にエラーが発生したときに分かりづらいので、PRにコメントを残すようにする * 古いget-api-diffを使ってるactionとの互換性をもたせる --------- Co-authored-by: おさむのひと <46447427+samunohito@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#12768 と同じです。
Regression in #12670
また、レポートの方でエラーになったときに何もエラーにならなかったので、エラーをプルリクに投げるようにしました。
Why
Additional info (optional)
普通の動作確認: anatawa12#10
upload-artifact@v3時代との互換性確認: anatawa12#11
report-api-diff内でのエラーの確認: anatawa12#12 (取得自体を無効化してます)
Checklist