Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 自分のdirect noteがuser list timelineに追加されない #12782

Merged

Conversation

anatawa12
Copy link
Member

What

Fix #12781

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 24, 2023
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0009aa3) 79.79% compared to head (7c4ada0) 79.79%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #12782   +/-   ##
========================================
  Coverage    79.79%   79.79%           
========================================
  Files          956      956           
  Lines       108808   108808           
  Branches      8374     8375    +1     
========================================
+ Hits         86822    86824    +2     
+ Misses       21986    21984    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@anatawa12
Copy link
Member Author

anatawa12 commented Dec 24, 2023

dbfallbackの方確認してないのでマージは少し待っててほしいです

@anatawa12
Copy link
Member Author

db fallbackはgenerateVisibilityQueryの方で問題なくフィルタされてそうなのでReady for mergeです

@syuilo syuilo merged commit fd040c5 into misskey-dev:develop Dec 25, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 25, 2023

🙏

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
* fix: 自分のdirect noteがuser list timelineに追加されない

* docs(changelog): Fix: 自分のdirect noteがuser list timelineに追加されない
takaion pushed a commit to takaion/misskingway that referenced this pull request Jan 27, 2024
* fix: 自分のdirect noteがuser list timelineに追加されない

* docs(changelog): Fix: 自分のdirect noteがuser list timelineに追加されない

(cherry picked from commit fd040c5)
madonuko pushed a commit to FyraLabs/nyaakey that referenced this pull request Feb 26, 2024
* fix: 自分のdirect noteがuser list timelineに追加されない

* docs(changelog): Fix: 自分のdirect noteがuser list timelineに追加されない
@anatawa12 anatawa12 deleted the user-list-timeline-direct-my-note branch March 10, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

自分のdirect noteがuser list timelineに追加されない
2 participants