Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 連合をホワイトリスト制にできるように #14643

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Sep 28, 2024

What

Resolve #2318

Why

#2318

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Sep 28, 2024
Copy link
Contributor

Thank you for sending us a great Pull Request! 👍
Please regenerate misskey-js type definitions! 🙏

example:

pnpm run build-misskey-js-with-types

Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -558,6 +558,15 @@
                         "string",
                         "null"
                       ]
+                    },
+                    "federation": {
+                      "type": "string"
+                    },
+                    "federationHosts": {
+                      "type": "array",
+                      "items": {
+                        "type": "string"
+                      }
                     }
                   },
                   "required": [
@@ -667,7 +676,9 @@
                     "urlPreviewMaximumContentLength",
                     "urlPreviewRequireContentLength",
                     "urlPreviewUserAgent",
-                    "urlPreviewSummaryProxyUrl"
+                    "urlPreviewSummaryProxyUrl",
+                    "federation",
+                    "federationHosts"
                   ]
                 }
               }
@@ -13925,6 +13936,20 @@
                       "string",
                       "null"
                     ]
+                  },
+                  "federation": {
+                    "type": "string",
+                    "enum": [
+                      "all",
+                      "none",
+                      "specified"
+                    ]
+                  },
+                  "federationHosts": {
+                    "type": "array",
+                    "items": {
+                      "type": "string"
+                    }
                   }
                 }
               }

Get diff files from Workflow Page

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 50.45872% with 54 lines in your changes missing coverage. Please review.

Project coverage is 39.83%. Comparing base (c3b0e1a) to head (af6eb53).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/admin/settings.vue 0.00% 37 Missing ⚠️
...kend/src/server/api/endpoints/admin/update-meta.ts 55.55% 8 Missing ⚠️
...ges/backend/src/core/activitypub/ApInboxService.ts 0.00% 2 Missing ⚠️
...kend/src/queue/processors/InboxProcessorService.ts 0.00% 2 Missing ⚠️
...ges/backend/src/server/api/endpoints/admin/meta.ts 85.71% 2 Missing ⚠️
.../backend/src/core/activitypub/ApResolverService.ts 0.00% 1 Missing ⚠️
...nd/src/queue/processors/DeliverProcessorService.ts 0.00% 1 Missing ⚠️
...ckages/backend/src/server/api/endpoints/ap/show.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14643      +/-   ##
===========================================
+ Coverage    39.65%   39.83%   +0.17%     
===========================================
  Files         1544     1544              
  Lines       193513   193604      +91     
  Branches      2506     3620    +1114     
===========================================
+ Hits         76731    77114     +383     
+ Misses      116217   115927     -290     
+ Partials       565      563       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo marked this pull request as ready for review September 28, 2024 08:58
@syuilo
Copy link
Member Author

syuilo commented Sep 28, 2024

マージするか

@syuilo syuilo merged commit f0d0cd2 into develop Sep 28, 2024
36 checks passed
@syuilo syuilo deleted the federation-allowed-hosts branch September 28, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ホワイトリスト連合
1 participant