Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): フォロワーへのメッセージ欄を改良 #14656

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

  • 吹き出しにする
  • 「フォロワーへのメッセージ」であることを明記する

image

Why

今のままだと何らかの警告表示に見間違えそうなので

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 99.14530% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.52%. Comparing base (a3d236c) to head (e35bc20).
Report is 204 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/components/MkFukidashi.vue 99.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14656       +/-   ##
============================================
- Coverage    41.74%   19.52%   -22.23%     
============================================
  Files         1549      716      -833     
  Lines       196555   101490    -95065     
  Branches      2767      987     -1780     
============================================
- Hits         82055    19815    -62240     
+ Misses      113939    81129    -32810     
+ Partials       561      546       -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit ca8cc01 into misskey-dev:develop Sep 30, 2024
24 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 30, 2024

🙏🏻

@kakkokari-gtyih kakkokari-gtyih deleted the enh-tweak-followmessage branch September 30, 2024 11:08
spalheapp added a commit to spalheapp/vmigos that referenced this pull request Sep 30, 2024
enhance(frontend): フォロワーへのメッセージ欄を改良 (misskey-dev#14656)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants