Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Core types in preparation for ts v4.7.4 #17

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -161,19 +161,19 @@ export class CoreVersionedRoute implements VersionedRoute {
) {
try {
const { body, params, query } = validate(req, validation.request, handler.options.version);
(req as Mutable<KibanaRequest>).body = body;
(req as Mutable<KibanaRequest>).params = params;
(req as Mutable<KibanaRequest>).query = query;
req.body = body;
req.params = params;
req.query = query;
} catch (e) {
return res.badRequest({
body: e.message,
});
}
} else {
// Preserve behavior of not passing through unvalidated data
(req as Mutable<KibanaRequest>).body = {};
(req as Mutable<KibanaRequest>).params = {};
(req as Mutable<KibanaRequest>).query = {};
req.body = {};
req.params = {};
req.query = {};
}

const response = await handler.fn(ctx, req, res);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ type KibanaRequestWithQueryVersion = KibanaRequest<
{ [ELASTIC_HTTP_VERSION_QUERY_PARAM]: unknown }
>;

export function hasQueryVersion(request: KibanaRequest): request is KibanaRequestWithQueryVersion {
export function hasQueryVersion(
request: Mutable<KibanaRequest>
): request is Mutable<KibanaRequestWithQueryVersion> {
return isObject(request.query) && ELASTIC_HTTP_VERSION_QUERY_PARAM in request.query;
}
export function removeQueryVersion(request: Mutable<KibanaRequestWithQueryVersion>): void {
Expand Down
Loading