Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ttl values being send now are actually the ttls not heights, so the
subtraction is not needed anymore.
Also @adiabat since the verification logic got changed the
overWire
variable is currently not used but the place to collect the positions for the playbooks would be in the else branch here and here.p.populate
is called for every root that was involved in the verification, so what you need to do to get all the "overwire" positions for the entire proof is: collect the "overwire" positions in each populate call and then concat all these together, sort them and store them in the playbook file.