Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csn: Use ttl not ttl - height #223

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Conversation

dergoegge
Copy link
Contributor

The ttl values being send now are actually the ttls not heights, so the
subtraction is not needed anymore.

Also @adiabat since the verification logic got changed the overWire variable is currently not used but the place to collect the positions for the playbooks would be in the else branch here and here.
p.populate is called for every root that was involved in the verification, so what you need to do to get all the "overwire" positions for the entire proof is: collect the "overwire" positions in each populate call and then concat all these together, sort them and store them in the playbook file.

The ttl values beeing send now are actually the ttls not heights, so the
subtractions is not needed anymore.
@kcalvinalvin
Copy link
Member

kcalvinalvin commented Nov 12, 2020

ACK

For future reference the subtraction happens here in the bridgenode side.

binary.BigEndian.PutUint32(
ttlArr[:], uint32(ttlRes.Height-c.createHeight))

@adiabat
Copy link
Contributor

adiabat commented Nov 12, 2020

Aha good catch, hopefully I haven't mixed it up anywhere else. It's tricky because both ways to record it would work (how long it lives, or when it dies)

@adiabat adiabat merged commit 98f0789 into mit-dci:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants