Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Java files with the expected file names on all platforms #1260

Merged
merged 2 commits into from
May 31, 2022
Merged

Generate Java files with the expected file names on all platforms #1260

merged 2 commits into from
May 31, 2022

Conversation

jedisct1
Copy link
Contributor

This replaces the sed script that depends on GNU sed with portable awk code.

Fixes generation of Java files on macOS and BSD.

@jedisct1
Generate Java files with the expected file names on all platforms
fd3c25f 
This replaces the sed script that depends on GNU sed with portable
awk code.

Fixes generation of Java files on macOS and BSD.
JasonGross
JasonGross reviewed May 28, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
JasonGross
JasonGross approved these changes May 31, 2022
View reviewed changes
Copy link
Collaborator

@JasonGross JasonGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might want to make this a bit more concise later, but it seems to work, thanks!

@JasonGross JasonGross merged commit 3ee1d93 into mit-plv:master May 31, 2022
@jedisct1 jedisct1 deleted the totitlecase-portable branch May 31, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonGross JasonGross JasonGross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedisct1 @JasonGross