Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with new num::Float::epsilon #1

Open
cuviper opened this issue Oct 3, 2016 · 1 comment
Open

Conflict with new num::Float::epsilon #1

cuviper opened this issue Oct 3, 2016 · 1 comment

Comments

@cuviper
Copy link

cuviper commented Oct 3, 2016

Just a heads up -- we recently added Float::epsilon in rust-num/num#231, and then a Crater run showed that simple_gaussian broke due to call ambiguity. See the logs here:
https://tools.taskcluster.net/task-inspector/#WJwHtMdHQmikycmFEZGd3Q/0

The ambiguous call is in your gen<F>, where F::epsilon could now either mean Float::epsilon or your Epsilon::epsilon. You could change it to a more explicit call to one of these choices. Or since you seem to just be extending Float, you might remove your epsilon.

@mitchmindtree
Copy link
Owner

@cuviper thanks for the heads up!

shybyte added a commit to shybyte/gaussian that referenced this issue Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants