fix: handle redis client error events #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context/Description Behind The Change
Under the hood this package creates its own instance of redis client to subscribe on redis events. This client is an instance of EventEmitter and in case of errors it emits
error
event. When this event doesn't have at least one subscriber - Node.js process is crashed.When using this library in some production service, it leads to uncontrolled crashes (no way to handled it via
process.on
listeners), so we have to add such listener here🚨 Potential Risks & What To Monitor After Deployment
Don't see any
🧑🔬 How Has This Been Tested?
🚚 Release Plan
Merge, get new version, bump everywhere in MM