Disable relocatable Qt with -no-feature-relocatable. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We build Qt with frameworks enabled. When frameworks are enabled, relocatable Qt uses the framework bundle to determine what the relocatable path to Qt libraries is: https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/global/qlibraryinfo.cpp?h=5.14.2#n537 We deploy standalone Qt dylibs without frameworks, so this causes a crash on launch with Qt 5.14: https://bugs.launchpad.net/mixxx/+bug/1871238 As a short-term fix, disable relocatable Qt. A longer term fix would be to build with frameworks disabled, or to actually ship frameworks instead of standalone libraries.
|
Okay, if this works for you locally, let's get a new build environment going on the build server. |
This was referenced Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We build Qt with frameworks enabled. When frameworks are enabled, relocatable Qt
uses the framework bundle to determine what the relocatable path to Qt libraries
is:
https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/global/qlibraryinfo.cpp?h=5.14.2#n537
We deploy standalone Qt dylibs without frameworks, so this causes a crash on
launch with Qt 5.14:
https://bugs.launchpad.net/mixxx/+bug/1871238
As a short-term fix, disable relocatable Qt. A longer term fix would be to build
with frameworks disabled, or to actually ship frameworks instead of standalone
libraries.
Tested by building environments locally and compiling/bundling Mixxx. The crash on start no longer occurs.