Fullscreen on Linux: fix issues caused by Ubuntu Unity workaround #11295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
daschuer
approved these changes
Feb 22, 2023
daschuer
added a commit
to daschuer/mixxx
that referenced
this pull request
Feb 22, 2023
ronso0
commented
Feb 24, 2023
| if (m_pMenuBar->isNativeMenuBar()) { | ||
| m_pMenuBar->setNativeMenuBar(false); | ||
| } | ||
| #endif |
There was a problem hiding this comment.
looks like this was already fixed in main by simply calling slotViewFullScreen(true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #11259
In order to fix #6072 the menubar is recreated and reconected when toggling fullscreen on Linux.
This causes issues on some distros.
Fixes #11281
Fixes #11294
VisibilityControlConnections in View menu after toglling fullscreen