Refactor/shrink modernize scopedtimer (Alternative to #13236) #13258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
library
engine
ui
build
scanner
waveform
vinylcontrol
soundsource
analyzer
soundio
labels
daschuer
requested changes
May 22, 2024
src/util/timer.h
Outdated
| #endif | ||
| m_maybeTimer = std::make_optional<Timer>(std::move(strKey), compute); | ||
| // | ||
| auto assembledKey = QString(std::forward<T>(key)); |
There was a problem hiding this comment.
This one is unfortunately not for free, because the compiler decides to create a local String copy:
https://godbolt.org/z/67M4MTc6j
Here is the `const QString&``version:
https://godbolt.org/z/9WbMedoej
There was a problem hiding this comment.
But in both cases, it still holds that capacity() == 0, thus the copy is not heap-allocated, so I don't really see a problem. Anyways, wdyt of the fixup. It avoids the construction of the temporary by use of an IILE.
Swiftb0y
force-pushed
the
refactor/shrink-modernize-scopedtimer-main
branch
3 times, most recently
from
3636289
to
46c7faa
Compare
Swiftb0y
force-pushed
the
refactor/shrink-modernize-scopedtimer-main
branch
from
46c7faa
to
4ece08b
Compare
|
Ready for review @daschuer. Thank you. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13236 but squashed and on top of main