Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak scratch parameters for Mixtrack Platinum #2028

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

iamcodemaker
Copy link
Contributor

The behavior here appears to have changed between 2.1 and 2.2. This new value tracks better with the actual location of the spinner.

@Be-ing
Copy link
Contributor

Be-ing commented Feb 13, 2019

Did you intend to target this for the 2.2 branch?

@daschuer
Copy link
Member

What exactly do you think have changed between 2.1 and 2.2?
The rate of the spinners in the GUI?
If this I a GUI Bug. We should change this Instead.

@iamcodemaker
Copy link
Contributor Author

I didn't test this on 2.2 but it should probably go there too. I'm not sure what changed, but I don't think this has anything to do with the GUI spinners. This change makes the position indicator on the controller track better with the platter movements. Something changed with how the platter movements were being handled at some point such that moving the platter moved the spinner/track slightly more than it should have. This change tweaks the parameters to compensate for this.

@Be-ing
Copy link
Contributor

Be-ing commented Feb 13, 2019

Have you adjusted your audio buffer size?

@iamcodemaker
Copy link
Contributor Author

It has nothing to do with audio buffer size as far as I can tell. I don't hear any issues there. The only thing affected appears to be how the jog wheel movements are interpreted.

@Be-ing Be-ing changed the base branch from master to 2.2 April 22, 2019 03:04
@Be-ing
Copy link
Contributor

Be-ing commented Apr 22, 2019

Considering the impact of this can't be tested without the actual hardware, I'll take your word that it's an improvement. It would be good to get confirmation from someone else with the hardware too. @JosepMaJAZ, could you test this?

I changed the target branch to 2.2, but your branch needs to be rebased and force pushed for it to be able to be merged to the 2.2 branch.

The behavior here appears to have changed between 2.1 and 2.2. This new
value tracks better with the actual location of the spinner.
@iamcodemaker
Copy link
Contributor Author

Rebased.

@Holzhaus
Copy link
Member

@Be-ing What's the status of this? Ready to merge?

@Holzhaus Holzhaus added this to the 2.2.4 milestone Jan 20, 2020
@iamcodemaker
Copy link
Contributor Author

Not sure. Depending on the version, I see different behavior. (or it could be different for tracks with different BPMs. I need to do some more testing)

@iamcodemaker
Copy link
Contributor Author

I just tested this with the 2.2.3 mac os release and it is definitely and improvement. So, IMO this is ready to merge.

@Holzhaus
Copy link
Member

Holzhaus commented Feb 4, 2020

I'd be in favor merging this now. @JosepMaJAZ did not answered since April, so I guess we have to trust that @iamcodemaker tested this thoroughly.

@Be-ing Do you agree?

@Be-ing
Copy link
Contributor

Be-ing commented Feb 4, 2020

Yes sorry to let this fall through the cracks.

@Be-ing Be-ing merged commit cc43a2d into mixxxdj:2.2 Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants