Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a donate button to README.md. #2537

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Add a donate button to README.md. #2537

merged 2 commits into from
Mar 9, 2020

Conversation

rryan
Copy link
Member

@rryan rryan commented Mar 8, 2020

This is pretty low-key. Thoughts?

@rryan rryan changed the title Add a donate button to REAMDE.md. Add a donate button to README.md. Mar 8, 2020
@Holzhaus
Copy link
Member

Holzhaus commented Mar 8, 2020

What about adding a github sponsor button instead? I think that is a bit more prominent. https://help.github.com/en/github/administering-a-repository/displaying-a-sponsor-button-in-your-repository

We can use the custom URL option to link to PayPal.

@rryan
Copy link
Member Author

rryan commented Mar 8, 2020

Here's what the Sponsor button would look like for comparison: https://github.com/rryan/mixxx (it has to be on master so I don't think you can preview from a PR).

Personally it feels more hidden to me, but I guess if the Sponsor button catches on them people will come to expect it at the top of the page.

It also takes 2 clicks and displays the bare URL which is kind of ugly.

@rryan
Copy link
Member Author

rryan commented Mar 9, 2020

on second thought, ¿porque no los dos?

@ronso0
Copy link
Member

ronso0 commented Mar 9, 2020

on second thought, ¿porque no los dos?

👍 Exactly, let's use both.

@ywwg
Copy link
Member

ywwg commented Mar 9, 2020

lgtm!

@rryan rryan merged commit 3f93585 into mixxxdj:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants