Create TrackSetTableModel as base for Crate- & PlaylistTableModel #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
reviewed
Apr 26, 2020
xeruf
force-pushed
the
refactor-tracksettablemodel
branch
from
872d825
to
16ef907
Compare
daschuer
reviewed
Apr 28, 2020
| TrackCollectionManager* const pTrackCollectionManager, | ||
| QObject* parent); | ||
| const char* settingsNamespace); |
There was a problem hiding this comment.
If you like this can be a QString initialized by a QStringLiteral()
Since we store the value finally, you may use a value parameter + std::move() when passing.
There was a problem hiding this comment.
This would have to be changed in quite a few places, so I'd like to refrain from that for now
xeruf
force-pushed
the
refactor-tracksettablemodel
branch
from
16ef907
to
1afd4ba
Compare
|
Since this is already quite big, I'd prefer to merge this as is and then actually implement TrackSetTableModel in a separate PR. @Be-ing could you merge? |
uklotzde
reviewed
May 20, 2020
|
I hope we can finally merge now :) Follow-up tasks:
|
|
@Holzhaus his comments are resolved :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.