Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Add clazy support #3295

Merged
merged 1 commit into from
Nov 13, 2020
Merged

GitHub Actions: Add clazy support #3295

merged 1 commit into from
Nov 13, 2020

Conversation

Holzhaus
Copy link
Member

Adds a clazy check to avoid introducing new warnings once we have a -Wrange-loop clean code base. Depends on #3291.

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, very helpful addition!! Ready to merge as soon as the check completes successfully.

@uklotzde
Copy link
Contributor

Passed. LGTM

We need to be prepared for failures in main after merging.

@uklotzde uklotzde merged commit 1c9f6ac into mixxxdj:2.3 Nov 13, 2020
@daschuer
Copy link
Member

This reports clazy as green, even though there are pending warning. Is this correct?

@uklotzde
Copy link
Contributor

This reports clazy as green, even though there are pending warning. Is this correct?

Only in external libraries as expected. Nothing to do for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants