Backport minor changes from #2656 (Custom Tags) #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have deliberately decided not to base this PR on 2.3, even though it would be possible. Let's release 2.3 as is and restrict all future work to main. |
Holzhaus
reviewed
May 6, 2021
daschuer
reviewed
May 6, 2021
|
It is annoying that all CI actions in forked repos are failing since recently: https://github.com/uklotzde/mixxx/actions/runs/818369140 Is anyone aware of this? |
I'll fix it. In thr meantime, just push some tags to your fork. |
|
I had also already a look, just building in: https://github.com/daschuer/mixxx/runs/2525042562 |
daschuer
approved these changes
May 7, 2021
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first set of minor changes backported from #2656. Please refer to the individual commit messages. Some extensions are not used yet, but extracting them beforehand helps to shrink the scope of #2656.
More PRs to follow. One after another.