Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Restrict transitive dependencies between libraries, part 2 #3849

Merged
merged 1 commit into from
May 9, 2021
Merged

CMake: Restrict transitive dependencies between libraries, part 2 #3849

merged 1 commit into from
May 9, 2021

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented May 9, 2021

...to prevent accidental dependencies.

Follow-up of #3847.

@uklotzde uklotzde added the build label May 9, 2021
@uklotzde uklotzde added this to the 2.4.0 milestone May 9, 2021
@uklotzde uklotzde requested a review from Holzhaus May 9, 2021 14:06
@uklotzde
CMake: Restrict transitive dependencies between libraries
255d77c 
...to prevent accidental dependencies.
Holzhaus
Holzhaus approved these changes May 9, 2021
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for CI.

@Holzhaus Holzhaus merged commit 458ba09 into mixxxdj:main May 9, 2021
@uklotzde uklotzde deleted the cmake_target_link_libraries branch May 9, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @Holzhaus