Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skins: fix remaining 'font leaks' #3958

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jun 6, 2021

now all widget fonts should be determined by skin stylesheets, i.e. impossible to override by OS settings.

For example when you choose a huge, italic serif type in OS font settings or with Qt5 Settings there should be no spot in Mixxx that is bigger than expected, italic or not the skin font.

Exceptions:

  • table header font size, though all characters should be visible (not cut off) and the header height should be about 10% taller than the font
  • context menu font size
  • main menu bar font, size and style

= spots where the system font or that set by Qt Settings (qt5ct)
could screw up the skin designs (cropped labels or table header)
@github-actions github-actions bot added the skins label Jun 6, 2021
@ronso0 ronso0 added this to the 2.3.0 milestone Jun 6, 2021
@ronso0 ronso0 changed the title Skins: fix remainng 'font leaks' Skins: fix remaining 'font leaks' Jun 6, 2021
@daschuer
Copy link
Member

daschuer commented Jun 7, 2021

I cannot spot a regression. Is there anything special to test or can we just merge?

@ronso0
Copy link
Member Author

ronso0 commented Jun 7, 2021

tiny risk of regression (now even harder to notice if the OS uses a decent sans-serif).
I took a brief look at each skins, confirmed the spots where I noticed the issues are fixed, just didn't want to merge myself.

@daschuer
Copy link
Member

daschuer commented Jun 7, 2021

Ok, thank you. Than I will hit the button.

@daschuer daschuer merged commit 827c8c2 into mixxxdj:2.3 Jun 7, 2021
@ronso0 ronso0 deleted the qssfontleaks branch June 7, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants