Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prohibit WWaveformViewer getting focused #4128

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jul 20, 2021

so the currently focused widget stays focused, which is crucial for toggling maximize_library
with when any of the library widgets has focus.

https://bugs.launchpad.net/mixxx/+bug/1936926

complements #2289 and #2307

@ronso0 ronso0 added this to the 2.4.0 milestone Jul 20, 2021
@github-actions github-actions bot added the ui label Jul 20, 2021
@ronso0 ronso0 requested a review from Holzhaus July 20, 2021 11:37
@ronso0
Copy link
Member Author

ronso0 commented Jul 20, 2021

2.3 is also affected but the sidebar is auto-focused there, so minimizing the library still works.

I'll rebase onto 2.3

@coveralls
Copy link

coveralls commented Jul 20, 2021

Pull Request Test Coverage Report for Build 1048865715

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.006%) to 28.638%

Files with Coverage Reduction New Missed Lines %
src/engine/cachingreader/cachingreaderworker.cpp 2 63.48%
src/engine/readaheadmanager.cpp 2 88.79%
Totals Coverage Status
Change from base Build 1047015866: -0.006%
Covered Lines: 20095
Relevant Lines: 70170

💛 - Coveralls

so the currently focused widget stays focused, which is crucial for toggling maximize_library
with <Spacebar> when any of the library widgets has focus.
@ronso0 ronso0 reopened this Jul 20, 2021
@ronso0 ronso0 removed this from the 2.4.0 milestone Jul 20, 2021
@ronso0 ronso0 requested review from Holzhaus and removed request for Holzhaus July 20, 2021 22:23
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this fixes / works around the bug linked. @Holzhaus do you want to take another look?

Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, LGTM and works fine.

@Swiftb0y No, if you can reproduce the original bug and confirmed that this fixes it and the code looks good to you, feel free to merge without my explicit approval :D

Btw, I noticed that the search box is focused by default after starting mixxx. This means that spacebar to maximize the library doesn't work until clicking the tracks table first. No idea if this is intended or a bug, but no big issue either way.

@Holzhaus Holzhaus merged commit 3546054 into mixxxdj:main Jul 23, 2021
@ronso0 ronso0 deleted the waveforms-no-focus branch July 23, 2021 15:36
@ronso0
Copy link
Member Author

ronso0 commented Jul 23, 2021

oh, it wasn't noticed that I actually wanted to target 2.3, but this went into main.
I'll open a new one.

@ronso0
Copy link
Member Author

ronso0 commented Jul 23, 2021

Btw, I noticed that the search box is focused by default after starting mixxx. This means that spacebar to maximize the library doesn't work until clicking the tracks table first. No idea if this is intended or a bug, but no big issue either way.

I can't reproduce that: no widget has focus, no matter if Mixxx was started in windowed or fullscreen mode (without controller).
btw, pressing Esc will always focus the tracks table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants