mapping for the Numark Mixtrack Pro FX

[h67ma]

Hi,

I've created a mapping for Mixtrack Pro FX.

The mapping was discussed in this thread and received some good feedback. It was originally created by @bad1dea5 (see here), then modified by me, with some help from @photoenix and others.

Manual PR

[uklotzde]

Thanks for contributing! Based on 2.3 and already accomplished by a PR for the manual, great 👍

As a First-time contributor we need to ask your to sign our CLA. No big deal, hopefully. Please comment here when done.

[h67ma]

Can I use my nickname in the agreement? Or do I need to use real name?

[uklotzde]

Can I use my nickname in the agreement? Or do I need to use real name?

Most of us have provided their real names. The list is not public and will not be published anywhere.

@daschuer Any advice?

[ronso0]

well, the names is listed in the About box, so decide for yourself if you prefer a nick or you real name.

the actual purpose is to
a) mention all contributors
b) being able to get in contact with you, in case something license-related changes and we need further pernission or something (ev. App store etc.), so a valid email address is required

[h67ma]

I've submitted the CLA (with nickname).

[Be-ing]

Can I use my nickname in the agreement? Or do I need to use real name?

I think it is most important that you provide an email address that you will respond to in the future if we ever need to contact past contributors.

[Swiftb0y]

Thanks for submitting your mapping.
Please make sure to install pre-commit for both the mixxx and the manual repository and run it on the files you are submitting.

[Swiftb0y]

Thanks. Last two comments. After that I'll have another look at the manual page and then thismapping is perfectly mergable (assuming no one else wants to have another look).

[h67ma]

Is some action still required of me? Or is the code ready to be merged?

[Holzhaus]

Is some action still required of me? Or is the code ready to be merged?

Don't worry, i think @Swiftb0y just needs to give his final approval and we need to proofread the manual changes (because we want to always merge both PRs at the same time).

[Swiftb0y]

Thank you, mapping looks very good.

[Holzhaus]

@uklotzde I think you requested changes. Please hVe a look and let us know if you're okay with mergingt this.

[uklotzde]

I don't remember that I requested changes 😅 Probably already resolved.

Let's merge the current version as is if everyone agrees as a baseline.

Did you read this new form post?
https://mixxx.discourse.group/t/numark-mixtrack-pro-fx/19561/57
I am unsure if it still applies or if this only affects a previous version.

[uklotzde]

This should be merged by someone who is also able to merge the corresponding manual PR.

[Be-ing]

This should be merged by someone who is also able to merge the corresponding manual PR.

@uklotzde do you not have write access to the manual repository?

[uklotzde]

This should be merged by someone who is also able to merge the corresponding manual PR.

@uklotzde do you not have write access to the manual repository?

No

[Be-ing]

Thank you for working on this and following through with the code review comments! :) And thanks @Swiftb0y for doing the review.

[h67ma]

Thanks for the in-depth review.

I will keep an eye on Mixxx updates and follow up with another PR when it will be possible to properly map FX selection.

[uklotzde]

@Be-ing Next time please stash the commits for controller mappings when merging to avoid flooding the Git history of the upstream repo.

[Be-ing]

Do you mean squash? I agree that would be appropriate but I have explicitly been told to not do that before.

[Holzhaus]

IIRC we discussed somewhere that squash-and-merge for controller mappings is appropriate, squashing for C++ changes is not.

[uklotzde]

Of course "squash", not "stash" 🙈

[uklotzde]

+60 tiny commits for a single controller mapping is just too much.