Fix switching from Shade to other skins #4421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
reviewed
Oct 14, 2021
src/mixxxmainwindow.cpp
Outdated
| @@ -779,7 +790,8 @@ void MixxxMainWindow::connectMenuBar() { | |||
| } | |||
|
|
|||
| void MixxxMainWindow::slotFileLoadSongPlayer(int deck) { | |||
| QString group = m_pCoreServices->getPlayerManager()->groupForDeck(deck - 1); | |||
| auto pPlayerManager = m_pCoreServices->getPlayerManager(); | |||
| QString group = pPlayerManager->groupForDeck(deck - 1); | |||
There was a problem hiding this comment.
Why is the static function groupForDeck() invoked on an instance and does not cause a linter warning?
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes debug assertions due to missing deck COs for Channel3/4
https://bugs.launchpad.net/mixxx/+bug/1946812
The issue was that VisualsManager::addDeck() was no longer called when the number ob deck increases.
This is a regression since
#3446 and
3c9435d
discovered when working on #2618