Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Beats iterator methods #4498

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Rename Beats iterator methods #4498

merged 3 commits into from
Nov 3, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Nov 2, 2021

The new iterator method names should be easier to grasp:

Description Old New
Beat on first marker cbegin() cfirstmarker()
Beat after last marker cend()
Beat on last marker clastmarker()
Earliest beat that can be represented without wraparound cearliest() cbegin()
Latest beat that can be represented without wraparound clatest() cend()

This was requested by @daschuer here: #4411 (comment)

@daschuer
Copy link
Member

daschuer commented Nov 3, 2021

Great, thank you.

daschuer
daschuer approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daschuer daschuer merged commit 3ac1a24 into mixxxdj:main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
code quality engine
Projects
Beats Refactoring
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Holzhaus @daschuer