Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfault when using midi.sendShortMsg and platform vnc #4635

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Fix segfault when using midi.sendShortMsg and platform vnc #4635

merged 1 commit into from
Jan 18, 2022

Conversation

daschuer
Copy link
Member

This is the rebase of #4619

@admindotnu @daschuer
Fix segfault when using midi.sendShortMsg and platform vnc
ac5e4c4 
This fixes lp1956144 by adding a missing null check
@daschuer daschuer mentioned this pull request Jan 18, 2022
Closed
uklotzde
uklotzde approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@uklotzde uklotzde added the changelog This PR should be included in the changelog label Jan 18, 2022
@uklotzde uklotzde merged commit bb0a004 into mixxxdj:2.3 Jan 18, 2022
@Holzhaus Holzhaus added this to the 2.3.2 milestone Jan 19, 2022
@uklotzde uklotzde mentioned this pull request Jan 19, 2022
Merged
@daschuer daschuer deleted the lp1956144 branch April 14, 2022 21:19
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
changelog This PR should be included in the changelog critical bug ui
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@daschuer @uklotzde @Holzhaus @admindotnu