Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrateFeature: add popup to avoid accidental remove of Crate #4700

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

fatihemreyildiz
Copy link
Contributor

I have fixed the accidental remove issue for crates as well by adding a popup just like I did for the playlists.

I know making popups everywhere is not a proper solution for accidental removal issues because these popups are affecting usability a lot. There are better solutions for that like discussed on the other Pull request; redo/undo button, check-boxes that we can change on the Options>Preferences “Warn before deleting a playlist\crate” or a checkbox like “Don’t show this again”, etc.

After adding this popup for the playlists, a few people wanted it for crates too. Therefore I did it. I want to contribute more so any feedback will be good for me :)

In my opinion for now popups can be our problem solver, then later on better solution can be implemented.

image

@fatihemreyildiz fatihemreyildiz changed the title to avoid accidental remove of Crate CrateFeature: add popup to avoid accidental remove of Crate Mar 18, 2022
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
At least this is a good intermediate solution and puts it into an equal state with playlists.
@ronso0 What do you think? merge?

@ronso0
Copy link
Member

ronso0 commented Mar 22, 2022

Nothing to add from my side.
Good to have a good intermediate solution for both playlists and crates.

@daschuer
Copy link
Member

Thanks!

@daschuer daschuer merged commit 02150fa into mixxxdj:main Mar 22, 2022
@ronso0 ronso0 added the changelog This PR should be included in the changelog label Mar 23, 2022
@daschuer daschuer added this to the 2.4.0 milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog This PR should be included in the changelog library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants