Skip to content

Commit

Permalink
Revert "[WPT] BFCache: service worker clients"
Browse files Browse the repository at this point in the history
This reverts commit 756b8281b5b76b2ae4561d3cf8c29a46689cf23f.

Reason for revert: New tests are very flaky. Example:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVylgELEgVGbGFrZSKKAWNocm9taXVtQGJsaW5rX3dlYl90ZXN0c0BleHRlcm5hbC93cHQvaHRtbC9icm93c2Vycy9icm93c2luZy10aGUtd2ViL2JhY2stZm9yd2FyZC1jYWNoZS9zZXJ2aWNlLXdvcmtlci1jb250cm9sbGVkLWFmdGVyLXJlc3RvcmUuaHR0cHMuaHRtbAw

https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyjgELEgVGbGFrZSKCAWNocm9taXVtQGJsaW5rX3dlYl90ZXN0c0BleHRlcm5hbC93cHQvaHRtbC9icm93c2Vycy9icm93c2luZy10aGUtd2ViL2JhY2stZm9yd2FyZC1jYWNoZS9zZXJ2aWNlLXdvcmtlci1jbGllbnRzLW1hdGNoYWxsLmh0dHBzLmh0bWwM

Original change's description:
> [WPT] BFCache: service worker clients
>
> This CL adds service worker tests for BFCache:
>
> - navigator.serviceWorker.controller
> - Fetch interception
> - Clients.claim()
> - Clients.matchAll() and
> - unregister().
>
> Expected behavior:
>
> - Controlled pages should remain controlled after
>   restored from BFCache, i.e.
>   navigator.serviceWorker.controller should remain non-null
>   and fetch should be intercepted.
> - Clients.claim() should evict pages
>   that would be affected from BFCache.
> - Clients.matchAll() shouldn't list pages in BFCache.
> - unregister() should evict controlled pages from BFCache.
>
> Failing tests:
>
> - service-worker-clients-claim.https.html:
>   On Safari/Firefox, Clients.claim() doesn't evict pages from BFCache.
> - service-worker-controlled-after-restore.https.html:
>   On Firefox, fetches are not intercepted after restored from
>   BFCache while `navigator.serviceWorker.controller` is non-null.
> - service-worker-unregister.https.html:
>   Controlled pages aren't evicted by unregister() (all browsers).
>
> Bug: 1107415, 1204228, w3c/ServiceWorker#1594
> Change-Id: I73233cf917e31dd91b974823d5490d0190f0eade
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201011
> Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
> Reviewed-by: Ben Kelly <wanderview@chromium.org>
> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1008327}

Bug: 1107415, 1204228, w3c/ServiceWorker#1594
Change-Id: I56ac20a492e2b1716d27867dc9c113b097833a6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3708190
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Phillis Tang <phillis@chromium.org>
Auto-Submit: Phillis Tang <phillis@chromium.org>
Commit-Queue: Phillis Tang <phillis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1014735}
NOKEYCHECK=True
GitOrigin-RevId: 334fb112459f785a9d6721f5b332df63fe7262c2
  • Loading branch information
philloooo authored and copybara-github committed Jun 16, 2022
1 parent fe07582 commit f8623b4
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 316 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -187,16 +187,3 @@ function runBfcacheTest(params, description) {
}
}, description);
}

// Call clients.claim() on the service worker
async function claim(t, worker) {
const channel = new MessageChannel();
const saw_message = new Promise(function(resolve) {
channel.port1.onmessage = t.step_func(function(e) {
assert_equals(e.data, 'PASS', 'Worker call to claim() should fulfill.');
resolve();
});
});
worker.postMessage({port: channel.port2}, [channel.port2]);
await saw_message;
}

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit f8623b4

Please sign in to comment.