Add Setting to Toggle Volume Sliders #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CamarataM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application suits my needs perfectly, but would mess with my audio settings in Android when idle, which for me are different for when I have headphones in and when I do not. At the OS level, my volume is set to 50% when I have my headphones plugged in but 0% when I don't have headphones in. When I would idle the application without headphones plugged in, my OS volume settings would be overwritten by audio-share, which is undesirable for my use case. This PR adds a toggle in the settings menu which disables the volume control functionality, allowing for the volume control to be controlled exclusively by the operating system both when headphones are plugged in and when not.
Feel free to merge my changes, implement them yourself in your own way, or neither. Regardless, thank you for making this program.