fix double declaration of protobuf and construction of the binary #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the link of the binary was reduced to a single line as it is more practical to reduce the number of lines and also to avoid the link_target so many times.
mkckr0
approved these changes
Apr 11, 2024
| @@ -22,7 +22,7 @@ elseif(${CMAKE_SYSTEM_NAME} STREQUAL "Linux") | |||
| set(PLATFORM_NAME "linux") | |||
| endif() | |||
|
|
|||
| message(STATUS "PLATFORMA_NAME ${PLATFORM_NAME}") | |||
| message(STATUS "PLATFORM_NAME ${PLATFORM_NAME}") | |||
| find_package(cxxopts CONFIG REQUIRED) | ||
| target_link_libraries(server-cmd PRIVATE cxxopts::cxxopts) | ||
| target_link_libraries(server-cmd PRIVATE asio::asio spdlog::spdlog protobuf::libprotobuf cxxopts::cxxopts) |
There was a problem hiding this comment.
target_link_libraries won't do link many times. It's a kind of declaration. After CMake configure the project, it will generate only one link command. One line or Multiline target_link_libraries have no difference.
| find_package(spdlog CONFIG REQUIRED) | ||
| target_link_libraries(server-cmd PRIVATE spdlog::spdlog) | ||
|
|
||
| find_package(Protobuf CONFIG REQUIRED) |
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.