Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numVisibleRows not initialized #395

Closed
KeesDijk opened this issue Jul 9, 2012 · 0 comments
Closed

numVisibleRows not initialized #395

KeesDijk opened this issue Jul 9, 2012 · 0 comments

Comments

@KeesDijk
Copy link

KeesDijk commented Jul 9, 2012

Hi,

first thanks for an amazing piece of software !

I ran into the following:
On line 141 numVisibleRows is declared but not initialized.

The first time numVisibleRows gets a value is on line 1353 in resizeCanvas.

But when options.autoHeight and options.leaveSpaceForNewRows are true numVisibleRows is used before that in line 1348. Resulting in a NaN for viewPortH
aleksj pushed a commit to aleksj/SlickGrid that referenced this issue Aug 25, 2012
@mleibman
Fix mleibman#395 - options.leaveSpaceForNewRows doesn't make sense wh…
3c16153 
…en options.autoHeight is on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mleibman @KeesDijk