Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop non-standard <function>.name assigning #584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SpeCT
Copy link

@SpeCT SpeCT commented Apr 21, 2013

This commit drops non-standard function naming. As I understood, removed code was used only for better stack tracing, but now fails (at least in Chrome) with next error.

TypeError: Cannot assign to read only property 'name' of function anonymous(_items,_args/**/) {

On first sight patched code works well with my SlickGrid configuration.

@SpeCT SpeCT mentioned this pull request Apr 21, 2013
2 tasks
@mleibman
Copy link
Owner

Why not keep the FF-specific "displayName"?

@SpeCT
Copy link
Author

SpeCT commented Apr 22, 2013

Hum. Well I'm not against this field at all, I'm just more webkit than gecko fan :) So when I found displayName not working in my shiny Canary I decided to save couple bytes and trim this cool, but still useless feature.

If you'd like to see displayName untouched – I will be able to create extra branch closer to the weekend.

@mleibman
Copy link
Owner

I would. It was there for a reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants