-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Support deleting tags from the run view UI #1933
Conversation
Agree with @smurching. We should at least prompt the user because this operation is irreversible. |
@harupy Thank you for working on this! +1 on adding a delete confirmation. Also, we can add the delete icon near the edit to separate the flow for these two actions. See an InVision prototype here: https://databricks.invisionapp.com/share/36NY54RMWPJ#/319871033_Edit-Inline |
Thanks @gioa for the design! @harupy you can likely implement the confirmation flow using antd's popconfirm component: https://ant.design/components/popconfirm/ |
@gioa @smurching Thanks for the suggestions! I just updated the code. Now it looks like: |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well, will merge once tests pass - thanks @harupy!
|
oh this bug is mentioned in #1927 |
@smurching @gioa |
@smurching Thanks! |
It's now possible to delete tags from the run view UI.
What changes are proposed in this pull request?
Support deleting tags from the run view UI
How is this patch tested?
Manually tested
Release Notes
Is this a user-facing change?
Run tags improvements. Adds the ability to delete tags from the run view UI.
What component(s) does this PR affect?
How should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes