Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Support deleting tags from the run view UI #1933

Merged
merged 3 commits into from
Oct 21, 2019

Conversation

harupy
Copy link
Member

@harupy harupy commented Oct 14, 2019

What changes are proposed in this pull request?

Support deleting tags from the run view UI

delete-tag

How is this patch tested?

Manually tested

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Run tags improvements. Adds the ability to delete tags from the run view UI.

What component(s) does this PR affect?

  • UI
  • CLI
  • API
  • REST-API
  • Examples
  • Docs
  • Tracking
  • Projects
  • Artifacts
  • Models
  • Scoring
  • Serving
  • R
  • Java
  • Python

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@smurching
Copy link
Collaborator

smurching commented Oct 15, 2019

Thanks @harupy for the PR! cc @gioa any thoughts on the UX here? Maybe we should prompt the user for confirmation before deleting the tag? Also, seems a little risky to have "Delete" so close to "Save"

@harupy
Copy link
Member Author

harupy commented Oct 15, 2019

Agree with @smurching. We should at least prompt the user because this operation is irreversible.

@gioa
Copy link
Contributor

gioa commented Oct 15, 2019

@harupy Thank you for working on this! +1 on adding a delete confirmation. Also, we can add the delete icon near the edit to separate the flow for these two actions. See an InVision prototype here: https://databricks.invisionapp.com/share/36NY54RMWPJ#/319871033_Edit-Inline

@smurching
Copy link
Collaborator

Thanks @gioa for the design! @harupy you can likely implement the confirmation flow using antd's popconfirm component: https://ant.design/components/popconfirm/

@harupy
Copy link
Member Author

harupy commented Oct 15, 2019

@gioa @smurching Thanks for the suggestions! I just updated the code. Now it looks like:

confirmation

@gioa
Copy link
Contributor

gioa commented Oct 15, 2019

LGTM!

Copy link
Collaborator

@smurching smurching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, will merge once tests pass - thanks @harupy!

@harupy
Copy link
Member Author

harupy commented Oct 16, 2019

test_model_save_load in tests/keras/test_keras_model_export.py failed.
https://travis-ci.org/mlflow/mlflow/jobs/598638360#L2340

@harupy
Copy link
Member Author

harupy commented Oct 16, 2019

oh this bug is mentioned in #1927

@harupy harupy closed this Oct 17, 2019
@harupy harupy reopened this Oct 17, 2019
@harupy
Copy link
Member Author

harupy commented Oct 17, 2019

@smurching @gioa
The Travis build passed this time.

@harupy harupy requested a review from smurching October 21, 2019 20:40
@smurching smurching merged commit 366b529 into mlflow:master Oct 21, 2019
@harupy harupy deleted the add-delete-tag branch October 22, 2019 01:59
@harupy
Copy link
Member Author

harupy commented Oct 22, 2019

@smurching Thanks!

@sueann sueann added the rn/feature Mention under Features in Changelogs. label Oct 29, 2019
@harupy harupy changed the title Support deleting tags from the run view UI [UI] Support deleting tags from the run view UI Nov 1, 2019
avflor pushed a commit to avflor/mlflow that referenced this pull request Aug 22, 2020
It's now possible to delete tags from the run view UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/feature Mention under Features in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants