Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests/mlflow/ to tests/ #196

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Conversation

andrewmchen
Copy link
Contributor

We should move the tests from tests/mlflow/ to tests/ since Python 2 will get confused about relative imports from test files located in tests/.

For example, if I have a file tests/test_foo.py. I cannot do

import mlflow.cli

since in Python 2 it will try to import the tests/mlflow/ package first.

Copy link
Contributor

@tomasatdatabricks tomasatdatabricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov-io
Copy link

Codecov Report

Merging #196 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   50.89%   50.91%   +0.02%     
==========================================
  Files          93       93              
  Lines        4761     4761              
==========================================
+ Hits         2423     2424       +1     
+ Misses       2338     2337       -1
Impacted Files Coverage Δ
mlflow/tracking/__init__.py 82.88% <0%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7633f2...d537d88. Read the comment docs.

@andrewmchen andrewmchen merged commit 2232a29 into mlflow:master Jul 26, 2018
jdlesage pushed a commit to jdlesage/mlflow that referenced this pull request Jul 10, 2020
sunishsheth2009 added a commit that referenced this pull request Jun 22, 2022
Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants