-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #825: add matplotlib to fix missing module error under docker image #827
Fix #825: add matplotlib to fix missing module error under docker image #827
Conversation
Failure in Travis CI (Job 2921) is on Python 3 keras related tests. AFAICT, these changes do not affect anything re: Keras. Two PR submitted after mine passed their CI checks. Possible one-time fluke. Trying to restart CI check by closing PR and re-opening. |
reopening to try and restart CI tests based on this posting |
Travis CI failed (Job 2926) again but this time on the R tests. The Python 3 Keras test passed w/o issue. Trying one more time to restart CI tests. |
Restarting CI tests. |
@jimthompson5802 Thank you for the contribution. After discussing it with the team, we feel that it may make sense to introduce an Ideally, the Would you be willing to add an |
@dbczumar Yes I can convert to One process question: Should I do this work on this current pull request or should I close this pull request and submit a new pull request when I've the |
@jimthompson5802 Thanks so much! I think it's fine to perform this work in the same PR, no reason to submit a new one. |
@dbczumar I've completed conversion to This is the log for a test run: |
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
=======================================
Coverage 65.75% 65.75%
=======================================
Files 22 22
Lines 800 800
=======================================
Hits 526 526
Misses 274 274 Continue to review full report at Codecov.
|
prep to restart travis ci build |
restart travis ci build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@jimthompson5802 I tried the I've updated the PR to divide the example into two subdirectories, one for each platform. Please let me know if this makes sense! |
@dbczumar No problem. Glad you guys have the resources to find these platform specific issues. Thank you. |
…er image (mlflow#827) * add matplotlib to fix missing module error under docker * restored prior version * Initial check-in * adapted to MLProject structure * Split example into platform-specific subdirectories * Add README explaining platform differences * README links * readme link fix * Reveert formatting changes to java readme
Fix #825: ImportError: No module named matplotlib.pyplot in examples/sklearn_elasticnet_diabetes/train_diabetes.py in mlflow docker image
Overview of change:
apt-get install -y build-essential
command.