Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require gitpython>=2.1.0 #98

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Conversation

aarondav
Copy link
Contributor

In #90, we started importing GitCommandNotFound, which is a class added in gitpython 2.1.0. Tested locally by downgrading my gitpython to this version, and the error does not show up.

Thanks @tomasatdatabricks

@codecov-io
Copy link

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   50.54%   50.54%           
=======================================
  Files          87       87           
  Lines        4184     4184           
=======================================
  Hits         2115     2115           
  Misses       2069     2069

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65dfaea...00538a2. Read the comment docs.

Copy link
Contributor

@tomasatdatabricks tomasatdatabricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aarondav aarondav merged commit 076ec92 into mlflow:master Jun 29, 2018
dbczumar pushed a commit to dbczumar/mlflow that referenced this pull request Jun 1, 2022
Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants