cache refactor #12
cache refactor #12
Conversation
| ); | ||
|
|
||
| load_source_and_add( | ||
| std::fs::read(&options_nixos_cache_path).map(|c| OptionsDatabase::load(&c)), |
There was a problem hiding this comment.
couldn't we use and_then here to flatten the error structure beforehand? the Errors type should be able to represent that possible io error, shouldn't it?
| Ok(true) | ||
| } | ||
| } | ||
| impl Cache for CommentsDatabase {} |
There was a problem hiding this comment.
This would ofc be prettier as a #[derive(Cache)] macro, although those are kind of annoying to implement. Generally something to keep in mind, but i don't think we need to necessarily do that now
src/nixpkgs_tree_docsource.rs
Outdated
| let new_keys = gen_keys()?; | ||
| let last = std::mem::replace(&mut self.keys, new_keys); | ||
|
|
||
| Ok(last != self.keys) |
There was a problem hiding this comment.
Generally i see the point in having update return information about if anything actually changed, but in cases like this, doing that check might actually have some performance implications (as it probably needs to iterate over all of the values pretty much, "undoing" the efficiency you've saved by doing the std::mem::replace. Are you sure that we actually need that return information, or that this causes no noticable increase in update-times?
|
Added a few comments, i think that's all I've noticed. everything else looks perfect! |
Completes mlvzk#12
No description provided.