Provide better error messages if camera not found

mminer · Jun 22, 2023 · 00f51de · 00f51de
1 parent c496bd0
commit 00f51de
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 22 deletions.
diff --git a/Editor/BigCameraInput.cs b/Editor/BigCameraInput.cs
@@ -9,16 +9,19 @@ namespace UnityEditor.BigImageRecorder
     /// </summary>
     class BigCameraInput : RecorderInput
     {
+        public bool HasCamera => camera != null;
         public BigCameraInputSettings InputSettings => settings as BigCameraInputSettings;
         public RenderTexture[,] OutputRenderTextures { get; private set; }
 
+        Camera camera;
         Matrix4x4[,] projectionMatrices;
 
         protected override void BeginRecording(RecordingSession session)
         {
             base.BeginRecording(session);
             OutputRenderTextures = CreateOutputRenderTextures(InputSettings);
-            projectionMatrices = CreateProjectionMatrices(InputSettings);
+            camera = GetTargetCamera(InputSettings.CameraTag);
+            projectionMatrices = CreateProjectionMatrices(InputSettings, camera);
         }
 
         protected override void Dispose(bool disposing)
@@ -36,7 +39,12 @@ protected override void Dispose(bool disposing)
         protected override void NewFrameReady(RecordingSession session)
         {
             base.NewFrameReady(session);
-            var camera = GetTargetCamera(InputSettings.CameraTag);
+
+            if (camera == null)
+            {
+                return;
+            }
+
             var originalTargetTexture = camera.targetTexture;
 
             for (var row = 0; row < InputSettings.Rows; row++)
@@ -70,10 +78,15 @@ protected override void NewFrameReady(RecordingSession session)
             return outputRenderTextures;
         }
 
-        static Matrix4x4[,] CreateProjectionMatrices(BigCameraInputSettings inputSettings)
+        static Matrix4x4[,] CreateProjectionMatrices(BigCameraInputSettings inputSettings, Camera camera)
         {
+            if (camera == null)
+            {
+                return null;
+            }
+
             var projectionMatrices = new Matrix4x4[inputSettings.Rows, inputSettings.Columns];
-            var camera = GetTargetCamera(inputSettings.CameraTag);
+            var nearClipPlane = camera.nearClipPlane;
 
             // Values to create the original projection matrix.
             // We multiply these by a modifier from -1 to 1 to get a partial projection matrix.
@@ -83,7 +96,7 @@ protected override void NewFrameReady(RecordingSession session)
             // Left:    left * 1, right * -1/3
             // Center:  left * 1/3, right * 1/3
             // Right:   left * -1/3, right * 1
-            var top = camera.nearClipPlane * Mathf.Tan(camera.fieldOfView * 0.5f * Mathf.Deg2Rad);
+            var top = nearClipPlane * Mathf.Tan(camera.fieldOfView * 0.5f * Mathf.Deg2Rad);
             var bottom = -top;
             var left = bottom * inputSettings.AspectRatio;
             var right = top * inputSettings.AspectRatio;
@@ -103,9 +116,9 @@ protected override void NewFrameReady(RecordingSession session)
                     var tileRight = right * (-1 + 2 * horizontalTilePercent * (column + 1));
 
                     var projectionMatrix = camera.projectionMatrix;
-                    projectionMatrix.m00 = 2 * camera.nearClipPlane / (tileRight - tileLeft);
+                    projectionMatrix.m00 = 2 * nearClipPlane / (tileRight - tileLeft);
                     projectionMatrix.m02 = (tileRight + tileLeft) / (tileRight - tileLeft);
-                    projectionMatrix.m11 = 2 * camera.nearClipPlane / (tileTop - tileBottom);
+                    projectionMatrix.m11 = 2 * nearClipPlane / (tileTop - tileBottom);
                     projectionMatrix.m12 = (tileTop + tileBottom) / (tileTop - tileBottom);
                     projectionMatrices[row, column] = projectionMatrix;
                 }
@@ -116,26 +129,35 @@ protected override void NewFrameReady(RecordingSession session)
 
         static Camera GetTargetCamera(string cameraTag)
         {
+            GameObject[] gameObjectsWithTag;
+
             try
             {
-                var cameras = GameObject
-                    .FindGameObjectsWithTag(cameraTag)
-                    .Select(gameObject => gameObject.GetComponent<Camera>())
-                    .Where(camera => camera != null)
-                    .ToList();
-
-                if (cameras.Count > 1)
-                {
-                    Debug.LogWarning($"Found more than one camera with tag '{cameraTag}'.");
-                }
-
-                return cameras.FirstOrDefault();
+                gameObjectsWithTag = GameObject.FindGameObjectsWithTag(cameraTag);
             }
             catch (UnityException)
             {
-                Debug.LogError($"Tag '{cameraTag}' does not exist.");
+                Debug.LogError($"[Big Image Recorder] Tag '{cameraTag}' does not exist.");
                 return null;
             }
+
+            var cameras = gameObjectsWithTag
+                .Select(gameObject => gameObject.GetComponent<Camera>())
+                .Where(camera => camera != null)
+                .ToList();
+
+            if (cameras.Count == 0)
+            {
+                Debug.LogError($"[Big Image Recorder] Found no camera with tag '{cameraTag}'.");
+                return null;
+            }
+
+            if (cameras.Count > 1)
+            {
+                Debug.LogWarning($"[Big Image Recorder] Found more than one camera with tag '{cameraTag}'.");
+            }
+
+            return cameras.First();
         }
     }
 }
diff --git a/Editor/BigCameraInputSettingsPropertyDrawer.cs b/Editor/BigCameraInputSettingsPropertyDrawer.cs
@@ -19,7 +19,6 @@ public override void OnGUI(Rect position, SerializedProperty property, GUIConten
             var outputWidth = property.FindPropertyRelative("outputWidth");
             var rows = property.FindPropertyRelative("rows");
 
-
             using (new EditorGUI.IndentLevelScope(-1))
             {
                 EditorGUILayout.PropertyField(cameraTag);

diff --git a/Editor/BigImageRecorder.cs b/Editor/BigImageRecorder.cs
@@ -20,7 +20,7 @@ class BigImageRecorder : GenericRecorder<BigImageRecorderSettings>
 
         protected override bool BeginRecording(RecordingSession session)
         {
-            if (!base.BeginRecording(session))
+            if (!base.BeginRecording(session) || !Input.HasCamera)
             {
                 return false;
             }