Skip to content

Commit

Permalink
Warn user if tile size exceeds max texture size
Browse files Browse the repository at this point in the history
  • Loading branch information
mminer committed May 20, 2021
1 parent b823267 commit f25e929
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
10 changes: 7 additions & 3 deletions Editor/BigCameraInput.cs
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,18 @@ protected override void NewFrameReady(RecordingSession session)
static RenderTexture[,] CreateOutputRenderTextures(BigCameraInputSettings inputSettings)
{
var outputRenderTextures = new RenderTexture[inputSettings.ColumnCount, inputSettings.RowCount];
var width = inputSettings.OutputWidth / inputSettings.ColumnCount;
var height = inputSettings.OutputHeight / inputSettings.RowCount;

for (var row = 0; row < inputSettings.RowCount; row++)
{
for (var column = 0; column < inputSettings.ColumnCount; column++)
{
var renderTexture = new RenderTexture(width, height, 0, RenderTextureFormat.ARGB32, RenderTextureReadWrite.Default);
var renderTexture = new RenderTexture(
inputSettings.TileWidth,
inputSettings.TileHeight,
0,
RenderTextureFormat.ARGB32,
RenderTextureReadWrite.Default);

renderTexture.Create();
outputRenderTextures[row, column] = renderTexture;
}
Expand Down
9 changes: 9 additions & 0 deletions Editor/BigCameraInputSettings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ public override int OutputWidth
[Tooltip("Number of vertical tiles.")]
[SerializeField] int rowCount = 2;

public int TileWidth => OutputWidth / ColumnCount;
public int TileHeight => OutputWidth / ColumnCount;

protected override bool ValidityCheck(List<string> errors)
{
var ok = true;
Expand Down Expand Up @@ -70,6 +73,12 @@ protected override bool ValidityCheck(List<string> errors)
ok = false;
}

if (TileWidth > SystemInfo.maxTextureSize || TileHeight > SystemInfo.maxTextureSize)
{
errors.Add($"Tile size exceeds the maximum texture size ({SystemInfo.maxTextureSize}).");
ok = false;
}

return ok;
}
}
Expand Down

0 comments on commit f25e929

Please sign in to comment.