fix: re-draw already loaded center images on change #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously if the image was already loaded, changing the value of the QR code would make it disappear. this change fixes that by immediately drawing the image if the complete property is true may help with #64 - although as reported that was essentially the reverse of this situation :/ ref: - https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously if the image was already loaded, changing the value of the QR code would make it disappear.
this change fixes that by immediately drawing the image if the complete property is true
may help with #64 - although as reported that was essentially the reverse of this situation :/
ref: