Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSOC] Add decomposition plotting #208

Merged
merged 52 commits into from
Jul 3, 2024
Merged

Conversation

tsbinns
Copy link
Collaborator

@tsbinns tsbinns commented Jun 20, 2024

As described in #182.

This adds support for visualising spatial filters and patterns as topomaps with the plot_filters and plot_patterns method of the CoherencyDecomposition class. Very similar to the methods of the same name in the CSP class of MNE's decoding module.

Unit tests added as well as a short example on how these methods can be used and the figures interpreted.

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments, the rendered example looks nice!

@wmvanvliet want to take a look?

mne_connectivity/decoding/decomposition.py Outdated Show resolved Hide resolved
mne_connectivity/decoding/decomposition.py Outdated Show resolved Hide resolved
Copy link
Contributor

@wmvanvliet wmvanvliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super small nitpicks. This looks great! The tutorial is informative and will be a nice addition to the docs.

examples/decoding/cohy_decomposition_plotting.py Outdated Show resolved Hide resolved
@tsbinns
Copy link
Collaborator Author

tsbinns commented Jun 26, 2024

Thanks both for the feedback! That should be everything addressed.

@adam2392
Copy link
Member

Vey slick figures :)

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tsbinns !

@larsoner larsoner merged commit f27793c into mne-tools:main Jul 3, 2024
12 checks passed
@tsbinns tsbinns deleted the decoding_plotting branch July 4, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants