This repository has been archived by the owner on Dec 31, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 350
upgrade mobx-react version from 6.2.2 to 6.2.3,There is an error #887
Labels
Comments
Please create a small reproduction. |
3 tasks
Yes have the same issue: We provide same component twice, because we use it for different stores, now it starts throwing errors. its quite annoying i had to downgrade to keep it working. reproducable by calling observer() twice on same class method but doing it manually: var observedClass1 = observer(ClassName);
var observedClass2 = observer(ClassName); |
ynejati
added a commit
to ynejati/mobx-react
that referenced
this issue
Jul 27, 2020
…ssage should get display name from 'target' and not 'this'
It would be nice to at least be able to disable this error/warning. |
"We provide same component twice, because we use it for different stores"
Why do you need to wrap a component twice in observer twice because you use
it for two different stores? Please provide some example code why the
warning wouldn't be correct in your case.
…On Mon, Jul 27, 2020 at 3:04 PM Joël Harkes ***@***.***> wrote:
It would be nice to at least be able to disable this error/warning.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#887 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN4NBADBVTCVVISPC5TVE3R5WCNNANCNFSM4PINWIYA>
.
|
The warning is fine. The real problem is getDisplayName ( mobx-react/src/observerClass.ts Line 26 in 376bff7
|
We will publish a fix soon, it was merely an oversight. Stick to the previous version for now, please. |
danielkcz
pushed a commit
that referenced
this issue
Jul 28, 2020
Just release 6.2.4. Thanks for reporting! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: